On Fri, Aug 03, 2018 at 03:29:02PM +0800, masonccyang@xxxxxxxxxxx wrote: > Mark Brown <broonie@xxxxxxxxxx> 已在 2018/08/02 下午 06:07:41 上寫入: > diff --git a/drivers/spi/spi-mxic.c b/drivers/spi/spi-mxic.c > index b786327..89889b0 100644 > --- a/drivers/spi/spi-mxic.c > +++ b/drivers/spi/spi-mxic.c > @@ -1,4 +1,4 @@ > -// SPDX-License-Identifier: GPL-2.0 > +/* SPDX-License-Identifier: GPL-2.0 */ > /* > * Copyright (C) 2018 Macronix International Co., Ltd. > * Other way, change it all to C++. > @@ -423,8 +423,13 @@ int mxic_spi_setup(struct spi_device *spi) > if (ret) > return ret; > > - clk_prepare_enable(mxic->send_clk); > + ret = clk_prepare_enable(mxic->send_clk); > + if (ret) > + return ret; > + > clk_prepare_enable(mxic->send_dly_clk); > + if (ret) > + return ret; > > return 0; > } > > is it OK? Like Boris says I was also asking for the enables to be moved out of spi_setup(), and as Trent noticed there's an issue with the rate setting too - that that should probably be moved into the transfer code.
Attachment:
signature.asc
Description: PGP signature
