Re: [PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 17, 2018 at 09:52:33AM +0200, Simon Horman wrote:
> On Wed, May 16, 2018 at 07:43:29PM +0200, Geert Uytterhoeven wrote:
> > Hi Uli,
> > 
> > On Wed, May 16, 2018 at 3:05 PM, Ulrich Hecht
> > <ulrich.hecht+renesas@xxxxxxxxx> wrote:
> > > From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
> > >
> > > This patch adds MSIOF device nodes for the R8A77995 SoC.
> > >
> > > Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
> > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> > > [uli: remove unimplemented ref clock]
> > 
> > I think you should remove the clock-names properties, too.
> > 
> > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx>
> > > ---
> > >  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 66 +++++++++++++++++++++++++++++++
> > >  1 file changed, 66 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > > index 2506f46..2f712ac 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > > @@ -783,6 +783,72 @@
> > >                         compatible = "renesas,prr";
> > >                         reg = <0 0xfff00044 0 4>;
> > >                 };
> > > +
> > > +               msiof0: spi@e6e90000 {
> > > +                       compatible = "renesas,msiof-r8a77995",
> > > +                                    "renesas,rcar-gen3-msiof";
> > > +                       reg = <0 0xe6e90000 0 0x0064>;
> 
> minor nit: s/0x0064/0x64/
> 
> Ulrich, could you consider reposing with the feedback from Geert and the
> minor nit above addressed?

Ulrich, ping for this series.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux