Re: [PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes

[Simon Horman <horms@xxxxxxxxxxxx>]

On Wed, May 16, 2018 at 07:43:29PM +0200, Geert Uytterhoeven wrote:
> Hi Uli,
> 
> On Wed, May 16, 2018 at 3:05 PM, Ulrich Hecht
> <ulrich.hecht+renesas@xxxxxxxxx> wrote:
> > From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
> >
> > This patch adds MSIOF device nodes for the R8A77995 SoC.
> >
> > Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> > [uli: remove unimplemented ref clock]
> 
> I think you should remove the clock-names properties, too.
> 
> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 66 +++++++++++++++++++++++++++++++
> >  1 file changed, 66 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > index 2506f46..2f712ac 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > @@ -783,6 +783,72 @@
> >                         compatible = "renesas,prr";
> >                         reg = <0 0xfff00044 0 4>;
> >                 };
> > +
> > +               msiof0: spi@e6e90000 {
> > +                       compatible = "renesas,msiof-r8a77995",
> > +                                    "renesas,rcar-gen3-msiof";
> > +                       reg = <0 0xe6e90000 0 0x0064>;

minor nit: s/0x0064/0x64/

Ulrich, could you consider reposing with the feedback from Geert and the
minor nit above addressed?

> > +                       interrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD 211>;
> > +                       clock-names = "msiof_clk";
> > +                       dmas = <&dmac1 0x41>, <&dmac1 0x40>,
> > +                              <&dmac2 0x41>, <&dmac2 0x40>;
> > +                       dma-names = "tx", "rx", "tx", "rx";
> > +                       power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> > +                       resets = <&cpg 211>;
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +                       status = "disabled";
> > +               };
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html