Re: [PATCH 2/3] spi: mxs: Switch to SPDX identifier

[Marek Vasut <marex@xxxxxxx>]

On 05/02/2018 09:18 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxx>
> 
> Adopt the SPDX license identifier headers to ease license compliance
> management.
> 
> Cc: Marek Vasut <marex@xxxxxxx>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
> ---
>  drivers/spi/spi-mxs.c | 48 +++++++++++++++++++-----------------------------
>  1 file changed, 19 insertions(+), 29 deletions(-)
> 
> diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
> index 3d216b9..6ac95a2 100644
> --- a/drivers/spi/spi-mxs.c
> +++ b/drivers/spi/spi-mxs.c
> @@ -1,32 +1,22 @@
> -/*
> - * Freescale MXS SPI master driver
> - *
> - * Copyright 2012 DENX Software Engineering, GmbH.
> - * Copyright 2012 Freescale Semiconductor, Inc.
> - * Copyright 2008 Embedded Alley Solutions, Inc All Rights Reserved.
> - *
> - * Rework and transition to new API by:
> - * Marek Vasut <marex@xxxxxxx>
> - *
> - * Based on previous attempt by:
> - * Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> - *
> - * Based on code from U-Boot bootloader by:
> - * Marek Vasut <marex@xxxxxxx>
> - *
> - * Based on spi-stmp.c, which is:
> - * Author: Dmitry Pervushin <dimka@xxxxxxxxxxxxxxxxx>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +//
> +// Freescale MXS SPI master driver
> +//
> +// Copyright 2012 DENX Software Engineering, GmbH.
> +// Copyright 2012 Freescale Semiconductor, Inc.
> +// Copyright 2008 Embedded Alley Solutions, Inc All Rights Reserved.

This C++ comment is horrid, I really hate it. If you want the first line
to be a C++ comment, while I find that terrible, I guess that's what was
forced upon everyone, but why make this whole block into a C++ comment ?
I don't think that is needed.

-- 
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html