On Tue, Apr 24, 2018 at 12:10:04AM +0200, Boris Brezillon wrote: > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > +#if IS_ENABLED(CONFIG_SPI_MEM) > > IS_BUILTIN(). > > You defined it as boolean, IS_ENABLE() is superfluous. > Sorry but I don't see the problem here. Yes, IS_BUILTIN() would work, > but IS_ENABLED() works fine too and has not impact on runtime perfs > (and probably near zero impact on compilation time). Anyway, I'll let > Mark decide if this is important enough to send a new version. Yeah, I'm fine with IS_ENABLED() - if nothing else it's defensive programming.
Attachment:
signature.asc
Description: PGP signature
