Hi Andy, On Tue, 24 Apr 2018 00:53:22 +0300 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Sun, Apr 22, 2018 at 9:35 PM, Boris Brezillon > <boris.brezillon@xxxxxxxxxxx> wrote: > > Some controllers are exposing high-level interfaces to access various > > kind of SPI memories. Unfortunately they do not fit in the current > > spi_controller model and usually have drivers placed in > > drivers/mtd/spi-nor which are only supporting SPI NORs and not SPI > > memories in general. > > > > This is an attempt at defining a SPI memory interface which works for > > all kinds of SPI memories (NORs, NANDs, SRAMs). > > > +config SPI_MEM > > + bool "SPI memory extension" > > > +#if IS_ENABLED(CONFIG_SPI_MEM) > > IS_BUILTIN(). > You defined it as boolean, IS_ENABLE() is superfluous. Sorry but I don't see the problem here. Yes, IS_BUILTIN() would work, but IS_ENABLED() works fine too and has not impact on runtime perfs (and probably near zero impact on compilation time). Anyway, I'll let Mark decide if this is important enough to send a new version. Regards, Boris -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html