On Wed, Apr 11, 2018 at 12:44:31AM +0200, Boris Brezillon wrote: > 2/ we create a new header (drivers/spi/internals.h?) for all > definitions that are meant for internal use (shared between spi.c > and spi-mem.c) > I personally prefer #2 as it provides a better separation between spi > and spi-mem code. > --- > drivers/spi/spi.c | 23 +++++------------------ > include/linux/spi/spi.h | 26 ++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+), 18 deletions(-) I prefer that too (if you prefer it you should go with it so it's the option on the table!). I'd go with drivers/spi/internals.h though so that it's even more obvious if something is being silly trying to use it when they shouldn't.
Attachment:
signature.asc
Description: PGP signature
