Re: [PATCH] spi: core: use gpio_request_one for configured gpio cs

[Chris Packham <Chris.Packham@xxxxxxxxxxxxxxxxxxx>]

On 27/07/17 21:47, Andy Shevchenko wrote:
> On Tue, Jul 25, 2017 at 12:44 AM, Chris Packham
> <Chris.Packham@xxxxxxxxxxxxxxxxxxx> wrote:
>> On 25/07/17 09:28, Martin Hundebøll wrote:
>>>> My patchset kind of stalled. I can do a refresh if there's interest.
>>>> But I really do need some help from people with access to hardware (I can
>>>> cover spi-orion and spi-fsl-espi but that's about it). After the
>>>> initial RFC series I posted in May I found that iMX platforms use the integer
>>>> cs_gpio field for both native chipselects and gpio based ones (values <
>>>> 0 indicate native CS) so again I'd be coding blind trying to
>>>> disentangle that.
>>   >
>>> My submission was more or less a fly-by patch, but I'd be happy to
>>> test/debug patches on spi-imx if you CC me on the series.
>>
>> Thanks for the offer. Now I just need to get a few round tuits.
> 
> Can you please, resend the latest you have with Cc'ing me?
> 
>>> Any other drivers with special gpio-cs handling?
>>   >
>>
>> Based on a quick grep spi-{atmel,davinci,ep93xx,gpio,imx,mt65xx,stm32}
>> all do stuff with cs_gpios outside of the spi core. I think at least
>> some of those a trivially handled if we let the core code do the gpio
>> management.
> 
> I have got ep93xx board from Mika to test, so, I can perhaps perform
> tests later, after I got pxa2xx working.
> 

Sure I'll rebase the series against linux-next#master I notice there is 
a rename of some variables in areas I'm touching.

Should come through shortly.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html