On Thu, Oct 06, 2016 at 08:36:29PM +0200, Heiner Kallweit wrote: > Am 06.10.2016 um 17:45 schrieb Mark Brown: > > Shouldn't we be warning if we encounter a DT that has this set since it > > probably indicates that something went wrong? > The values of mpc8xxx_spi->rx_shift and mpc8xxx_spi->tx_shift were > overwritten in fsl_espi_setup_transfer anyway. Therefore the removed > code effectively was dead code. > As we just remove dead code and don't change the behavior of the driver > I see no need to introduce an additional check / warning. There's still the potential to either uncover an existing bug that only worked by accident or to catch some future bug that someone introduces. The existing code may have problems but that doesn't mean it's not a good idea to do a good job now.
Attachment:
signature.asc
Description: PGP signature
