Re: [PATCH 02/11] spi: fsl-espi: remove unneeded check for SPI_QE_CPU_MODE

[Heiner Kallweit <hkallweit1@xxxxxxxxx>]

Am 06.10.2016 um 17:45 schrieb Mark Brown:
> On Sun, Oct 02, 2016 at 02:22:48PM +0200, Heiner Kallweit wrote:
>> SPI_QE_CPU_MODE doesn't exist for ESPI and is set by of_mpc8xxx_spi_probe
>> based on DT property "mode". This property is not defined for ESPI,
>> see Documentation/devicetree/bindings/spi/fsl-spi.txt
>> Therefore remove the check.
> 
> Shouldn't we be warning if we encounter a DT that has this set since it
> probably indicates that something went wrong?
> 
The values of mpc8xxx_spi->rx_shift and mpc8xxx_spi->tx_shift were
overwritten in fsl_espi_setup_transfer anyway. Therefore the removed
code effectively was dead code.
As we just remove dead code and don't change the behavior of the driver
I see no need to introduce an additional check / warning.

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html