On Tue, Jul 12, 2016 at 06:06:04PM -0400, Kamal Dasu wrote: > The NS* SoC SPI blocks has hw glue logic specific to MSPI+BSPI, so > the re-usability of an interrupt controller driver for this logic is > limited. The spi only (spi protocol) block does use l2 controller, > however for the MSPI+BSPI block used for the spi-nor flash had to > introduce the code to handle l1 interrupts within the code itself. In > this case can the driver be accepted without having to introduce a new > intc driver ?. It's not really about reuse, it's about maintainability. All the code for handling this within the driver is quite unusual and makes the driver harder to understand and review. That's going to have an impact now and make things harder to follow in future too. Fitting in with the frameworks means that we get the benefit of the structure and support code that the frameworks provide while minimizing the amount of unusal code in the driver. You may find that you may even be able to use one of the existing generic interrupt controller drivers if the hardware is simple enough.
Attachment:
signature.asc
Description: PGP signature
