Re: [PATCH RESEND] spi: spidev: Allow matching DT compatible strings from ACPI

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Wed, Jun 29, 2016 at 08:20:59PM +0100, Mark Brown wrote:
> On Wed, Jun 29, 2016 at 09:51:55PM +0300, Mika Westerberg wrote:
> > On Wed, Jun 29, 2016 at 07:31:01PM +0100, Mark Brown wrote:
> 
> > > And we're *sure* that's going to be maintained?  People do use the
> > > fallback matching that DT does, I don't trust the ACPI maintainers not
> > > to do the same thing.
> 
> > That fallback matching does not even work in ACPI like I told you
> > already. We have no plans to do anything like that either. That's the
> > reason why we complain if there is PRP0001 without compatible string.
> 
> No, you're completely missing the point here.  The problem is someone
> using something like linux,spidev as a compatible string and going into
> fallback matching on SPI bus IDs rather than compatible strings.  I just
> don't have confidence that someone isn't going to try to add that
> fallback path given that it's used for DT.

If someone is using "linux,spidev" as compatible string it will not
match anything and we are not going to add any kind of fallback to the
ACPI core for that.

Of course we cannot predict what happens in the future but is it really
preventing merging of this patch?

What I'm simply trying to achieve is to use the existing two DT
compatible strings from ACPI. I've tested that it works fine and
provided you all the evidence that it does not break the check for
misusing DT.

> > > Right, but rather than just define a translation from ACPI to DT and use
> > > the DT code paths in their entirety for the relevant nodes what's
> > > happening is that there's a shim layer between ACPI and DT which sort of
> > > emulates bits of the DT interfaces but not quite and can lead to
> > > surprises.
> 
> > Maybe but currently it works fine. And if problems are found they will
> > be fixed as usual.
> 
> I'm worried that the reason it's working fine may be that there is very
> little usage, and that there may be more gotchas like we're already
> seeing lurking about.

With more usage I'm sure we can improve things. After all the end goal
is to let single driver to work on both DT and ACPI systems with minimal
changes. If you think the current implementation is flawed, nothing
prevents you from proposing better alternative :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html