Re: [PATCHv4 2/2] bindings: spi: Add clock entries for spi-xilinx

[Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxx>]

On Sat, Mar 12, 2016 at 3:35 PM, Sören Brinkmann
<soren.brinkmann@xxxxxxxxxx> wrote:
> On Sat, 2016-03-12 at 13:30:37 +0530, Shubhrajyoti Datta wrote:
>> Add clock description for spi-xilinx
>>
>> Signed-off-by: Shubhrajyoti Datta <shubhraj@xxxxxxxxxx>
>> ---
>> v3
>> Add a clock name
>> v4
>> Correct the name
>>  .../devicetree/bindings/spi/spi-xilinx.txt         |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/spi-xilinx.txt b/Documentation/devicetree/bindings/spi/spi-xilinx.txt
>> index c7b7856..07ec09a 100644
>> --- a/Documentation/devicetree/bindings/spi/spi-xilinx.txt
>> +++ b/Documentation/devicetree/bindings/spi/spi-xilinx.txt
>> @@ -7,6 +7,9 @@ Required properties:
>>  - interrupts         : Property with a value describing the interrupt
>>                         number.
>>  - interrupt-parent   : Must be core interrupt controller
>> +- clocks: Input clock specifier. Refer to common clock bindings.
>> +- clock-names: tuple listing input clock names.
>> +     Required elements: "s_axi_aclk"
>
> I thought there were too clocks? If the IP has two clocks, I think both
> should be added and supported here.
>
Ok sure

>>
>>  Optional properties:
>>  - xlnx,num-ss-bits   : Number of chip selects used.
>> @@ -14,6 +17,8 @@ Optional properties:
>>  Example:
>>       axi_quad_spi@41e00000 {
>>                       compatible = "xlnx,xps-spi-2.00.a";
>> +                     clocks = <&clkc 15>;
>> +                     clock-names = "spi_fclk";
>
> Doesn't match the binding documented above.

missed it will update thanks.

>
>         Sören
> --
> To unsubscribe from this list: send the line "unsubscribe linux-spi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html