Re: [PATCH 1/2] spi: sh-msiof: Add rcar fallback compatibility string

[Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx>]

Hi Geert-san,

Thanks for your review.

2015-12-24 23:58 GMT+09:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
> Hi Kaneko-san,
>
> On Thu, Dec 24, 2015 at 12:16 PM, Yoshihiro Kaneko
> <ykaneko0929@xxxxxxxxx> wrote:
>> Add fallback compatibility string for R-Car Gen2 and Gen3.
>> This is in keeping with the fallback scheme being adopted wherever
>> appropriate for drivers for Renesas SoCs.
>> In Addition, this patch deletes the compat strings for old SoCs.
>
>  "renesas,sh-mobile-msiof" is in use in arch/arm/boot/dts/sh73a0.dtsi, so you
> cannot just delete it.

I missed it. I have checked it on wrong tree.

Thanks,
kaneko

>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/spi/sh-msiof.txt | 11 ++++++++---
>>  drivers/spi/spi-sh-msiof.c                         |  5 +++--
>>  2 files changed, 11 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/sh-msiof.txt b/Documentation/devicetree/bindings/spi/sh-msiof.txt
>> index aa005c1..d9d89ee 100644
>> --- a/Documentation/devicetree/bindings/spi/sh-msiof.txt
>> +++ b/Documentation/devicetree/bindings/spi/sh-msiof.txt
>> @@ -2,8 +2,8 @@ Renesas MSIOF spi controller
>>
>>  Required properties:
>>  - compatible           : "renesas,msiof-<soctype>" for SoCs,
>> -                        "renesas,sh-msiof" for SuperH, or
>> -                        "renesas,sh-mobile-msiof" for SH Mobile series.
>
>  "renesas,sh-mobile-msiof" is in use.
>
>> +                        "renesas,rcar-gen2-msiof" for R-Car Gen2 series, or
>> +                        "renesas,rcar-gen3-msiof" for R-Car Gen3 series.
>>                          Examples with soctypes are:
>>                          "renesas,msiof-r8a7790" (R-Car H2)
>>                          "renesas,msiof-r8a7791" (R-Car M2-W)
>
>> diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
>> index a7934ab..283fb31 100644
>> --- a/drivers/spi/spi-sh-msiof.c
>> +++ b/drivers/spi/spi-sh-msiof.c
>
>> @@ -971,8 +972,8 @@ static const struct sh_msiof_chipdata r8a779x_data = {
>>  };
>>
>>  static const struct of_device_id sh_msiof_match[] = {
>> -       { .compatible = "renesas,sh-msiof",        .data = &sh_data },
>> -       { .compatible = "renesas,sh-mobile-msiof", .data = &sh_data },
>
>  "renesas,sh-mobile-msiof" is in use.
>
>> +       { .compatible = "renesas,rcar-gen2-msiof", .data = &r8a779x_data },
>> +       { .compatible = "renesas,rcar-gen3-msiof", .data = &r8a779x_data },
>>         { .compatible = "renesas,msiof-r8a7790",   .data = &r8a779x_data },
>>         { .compatible = "renesas,msiof-r8a7791",   .data = &r8a779x_data },
>>         { .compatible = "renesas,msiof-r8a7792",   .data = &r8a779x_data },
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html