Re: [PATCH 1/2] spi: sh-msiof: Add rcar fallback compatibility string

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Kaneko-san,

On Thu, Dec 24, 2015 at 3:58 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
>> --- a/drivers/spi/spi-sh-msiof.c
>> +++ b/drivers/spi/spi-sh-msiof.c
>
>> @@ -971,8 +972,8 @@ static const struct sh_msiof_chipdata r8a779x_data = {
>>  };
>>
>>  static const struct of_device_id sh_msiof_match[] = {
>> -       { .compatible = "renesas,sh-msiof",        .data = &sh_data },
>> -       { .compatible = "renesas,sh-mobile-msiof", .data = &sh_data },
>
>  "renesas,sh-mobile-msiof" is in use.
>
>> +       { .compatible = "renesas,rcar-gen2-msiof", .data = &r8a779x_data },
>> +       { .compatible = "renesas,rcar-gen3-msiof", .data = &r8a779x_data },

Have you tested this?
The current driver doesn't work well on r8a7795/salvator-x for me
(e.g. the clock
signal starts and stops too soon). Hence I think it's a bit premature to make
this change.

I'll look into the workarounds in the BSP soon...

>>         { .compatible = "renesas,msiof-r8a7790",   .data = &r8a779x_data },
>>         { .compatible = "renesas,msiof-r8a7791",   .data = &r8a779x_data },
>>         { .compatible = "renesas,msiof-r8a7792",   .data = &r8a779x_data },

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html