hi, Grygorii Strashko <grygorii.strashko@xxxxxx> writes: > On 11/02/2015 05:20 PM, Felipe Balbi wrote: >> Grygorii Strashko <grygorii.strashko@xxxxxx> writes: >> >>> On 10/29/2015 03:57 PM, Felipe Balbi wrote: >>>> there's no need to call pm_runtime_get_sync() >>>> followed by pm_runtime_put(). We should, instead, >>>> just call pm_runtime_put_sync() and pm_runtime_disable(). >>> >>> Sry, but why do we need to call pm_runtime_put[_sync]() here? >>> >>> My be just pm_runtime_disable() will be ok? >> >> and disable with unbalanced pm_runtime_get() ? >> > > Which one is unbalanced pm_runtime_get()? > There are no pm_runtime_get() in probe, so there you are > going to introduce unbalanced pm_runtime_put_sync() actually :( look at ti_qspi_setup(). I _do_ see, however, that it calls pm_runtime_put_autosuspend() in the same function; what happens if driver is removed after ti_qspi_setup() runs but before put_autosuspend() has time to actually run ? -- balbi
Attachment:
signature.asc
Description: PGP signature
