Re: [PATCH 2/3] spi: fsl-(e)spi: simplify cleanup code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 26, 2015 at 08:14:23PM +0200, Heiner Kallweit wrote:
> Am 25.08.2015 um 19:45 schrieb Mark Brown:
> > On Sun, Aug 23, 2015 at 02:21:53PM +0200, Heiner Kallweit wrote:

> >>  static int of_fsl_espi_remove(struct platform_device *dev)
> >>  {
> >> -	return mpc8xxx_spi_remove(&dev->dev);
> >> +	return 0;
> >>  }

> > You should be able to remove empty functions like this one.

> When checking I just recognized that this (now temporarily empty)
> function is the remove callback of the platform driver.
> AFAIK providing a remove callback is mandatory.
> Is it therefore ok to have a temporarily empty function here?

No, remove callbacks are completely optional.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux