Re: [PATCH 2/3] spi: fsl-(e)spi: simplify cleanup code

[Heiner Kallweit <hkallweit1@xxxxxxxxx>]

Am 25.08.2015 um 19:45 schrieb Mark Brown:
> On Sun, Aug 23, 2015 at 02:21:53PM +0200, Heiner Kallweit wrote:
> 
>>  static int of_fsl_espi_remove(struct platform_device *dev)
>>  {
>> -	return mpc8xxx_spi_remove(&dev->dev);
>> +	return 0;
>>  }
> 
> You should be able to remove empty functions like this one.
> 
When checking I just recognized that this (now temporarily empty)
function is the remove callback of the platform driver.
AFAIK providing a remove callback is mandatory.
Is it therefore ok to have a temporarily empty function here?

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html