Re: [alsa-devel] Fwd: [PATCH 1/1] SPI : spi-pxa2xx : fix spi init of WM510205 codec via ACPI (resend)

[Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Aug 10, 2015 at 10:00:38AM +0200, Christian Hartmann wrote:
> Hi again,
> 
> in the case of CONFIG_OF (this machine has no OF) the arizona_of_get_core_pdata
> sets also gpio_defaults for struct pdata, which I had not added into
> the #else switch (CONFIG_OF is not set).
> 
> All I have is an one example in
> Documentation/devicetree/bindings/mfd/arizona.txt.
> 
> What should I do here cause I do not now the defaults but they seem to
> be needed too and I cannot use devicetree here.
> Where can I get the gpio-defaults or how can I use gpiolib to extract
> these defaults and gpio pins as expected?
> 

Those defaults are for the GPIOs on the CODEC and have nothing to
do with getting the reset and ldo enable working. You only need
to set them if you are going to use pins on the CODEC to control
something else.

> 
> 
> Looking again ( and again at the code), I have to use a function
> similar to arizona_of_get_named_gpio to find all of these pins, is
> there a function for the acpi case?

No as we have discussed currently the driver has no support for
ACPI. I would imagine there is an ACPI equivalent of
of_get_named_gpio which is what the function you mention uses to
get the actual GPIO number though. But I don't know what the
exact function is.

Thanks,
Charles

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html