Re: [PATCH 1/2] spi: rspi: Remove obsolete rspi-rz platform_device_id entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 24, 2015 at 11:19:09AM +0200, Geert Uytterhoeven wrote:

> Unlike the sh_eth case, I don't get a warning if CONFIG_OF=n, because
> rspi_rz_ops is const. Not even with a picky gcc 4.1.2.

OTOH what's 4.2 going to do, or clang...  

> > Please drop this one, will fix.

> And unlike the sh_eth case, this cannot be fixed with one #ifdef without
> restructuring the whole driver.

> Hence inclined to withdraw my drop requst.
> Mark, what do you think? Is this patch OK as-is?

Given that it's only removing one line I'm not sure it's worth the
effort.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux