Re: [PATCH 2/2] spi: rspi: Remove obsolete qspi platform_device_id entry

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Wed, Jun 24, 2015 at 10:01 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Tue, Jun 23, 2015 at 3:02 PM, Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
>> Since commit a483dcbfa21f919c ("ARM: shmobile: lager: Remove legacy
>> board support"), R-Car Gen2 SoCs are only supported in generic DT-only
>> ARM multi-platform builds.  The driver doesn't need to match platform
>> devices by name anymore, hence remove the corresponding
>> platform_device_id entry.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>> ---
>>  drivers/spi/spi-rspi.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c
>> index 56216b205e0f2c34..3e82b84c9ed48b2f 100644
>> --- a/drivers/spi/spi-rspi.c
>> +++ b/drivers/spi/spi-rspi.c
>> @@ -1295,7 +1295,6 @@ error1:
>>
>>  static const struct platform_device_id spi_driver_ids[] = {
>>         { "rspi",       (kernel_ulong_t)&rspi_ops },
>> -       { "qspi",       (kernel_ulong_t)&qspi_ops },
>>         {},
>>  };
>
> qspi_ops is still used for DT matching, but rspi_of_match[] is protected
> by #ifdef CONFIG_OF, so this may lead to compiler warnings.

(same as rspi_rz_ops)

Unlike the sh_eth case, I don't get a warning if CONFIG_OF=n, because
qspi_ops is const. Not even with a picky gcc 4.1.2.

> Please drop this one, will fix.

And unlike the sh_eth case, this cannot be fixed with one #ifdef without
restructuring the whole driver.

Hence I'm inclined to withdraw my drop requst.
Mark, what do you think? Is this patch OK as-is?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html