Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

[Michael Welling <mwelling@xxxxxxxx>]

On Thu, May 07, 2015 at 08:27:58PM +0100, Mark Brown wrote:
> On Thu, May 07, 2015 at 02:20:19PM -0500, Michael Welling wrote:
> > On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote:
> 
> > > makes things easier to review and helps people trying to understand the
> 
> > Do you have any other suggestions or comments on the patch so that I
> > can incorporate those changes as well in the patch series?
> 
> No, that's part of the "easier to review" bit.

The first two hunks are the only GPIO related code.

The rest is all conversion to transfer_one.
 
> 
> > I noticed a few oddities in the code when converting.
> 
> > For instance:
> > http://lxr.free-electrons.com/source/drivers/spi/spi-omap2-mcspi.c#L1225
> 
> > What is the point of trying to print tx or rx given the if statement
> > insures that rx_buff and tx_buff are NULL?
> 
> I expect it's just a buggy test.

Not sure I understand what you mean.


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html