Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

[Michael Welling <mwelling@xxxxxxxx>]

On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote:
> On Wed, May 06, 2015 at 06:37:52PM -0500, Michael Welling wrote:
> > This patch allows for GPIOs specified in the devicetree to be used as SPI
> > chipselects on TI OMAP2 SoCs.
> > 
> > Tested on the AM3354.
> > 
> > Signed-off-by: Michael Welling <mwelling@xxxxxxxx>
> > ---
> > v3: Switches driver to use transfer_one instead of transfer_one_message
> > allowing the spi core to handle toggling GPIO chip selects if specified.
> 
> This is now two changes so it should be two patches, one converting to
> transfer_one() and another adding the GPIO chip select support.  This
> makes things easier to review and helps people trying to understand the
> git history in the future (right now there's not even a mention of the
> conversion to transfer_one() in the changelog).

Okay. I will break it down into a patch series.

Do you have any other suggestions or comments on the patch so that I
can incorporate those changes as well in the patch series?

I noticed a few oddities in the code when converting.

For instance:
http://lxr.free-electrons.com/source/drivers/spi/spi-omap2-mcspi.c#L1225

What is the point of trying to print tx or rx given the if statement
insures that rx_buff and tx_buff are NULL?

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html