Re: [PATCH 1/2] spi: add spi_statistics framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 04, 2015 at 03:39:10PM +0200, Martin Sperl wrote:

> Typically (i understood) you want things as separate patches, so I 
> did split the API change from the implementation details:

Separate *logical* patches, just splitting things up by file isn't
really helping unless the change is very large.

> Patch1/2 with the framework/API and the other with the implementation.

> Also the Patch2/2 requires the “to_spi_master” method from Patch1/2.

> You want now everything in a single patch or you want patch 1/2
> split into 2 distinct patches?

I'd expect to see to_spi_master() in a separate patch.  I don't
particularly see a need to separate out the header file changes from the
implementation.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux