> On 04.05.2015, at 15:24, Mark Brown <broonie@xxxxxxxxxx> wrote: > > Two problems here: > - This doesn't do what the subject line says it does (it's purely a > modification to the header). > - This is two not obviously related changes in a single commit. Typically (i understood) you want things as separate patches, so I did split the API change from the implementation details: Patch1/2 with the framework/API and the other with the implementation. Also the Patch2/2 requires the “to_spi_master” method from Patch1/2. You want now everything in a single patch or you want patch 1/2 split into 2 distinct patches? Other things that you think needs change so that i can incorporate those as well prior to resubmitting? thanks -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html