On Mon, Mar 30, 2015 at 01:55:12PM +0300, Andy Shevchenko wrote:
> On Mon, 2015-03-30 at 13:30 +0300, Dan Carpenter wrote:
> > @@ -791,6 +791,7 @@ static unsigned int pxa2xx_ssp_get_clk_div(struct driver_data *drv_data,
> > switch (drv_data->ssp_type) {
> > case QUARK_X1000_SSP:
> > clk_div = quark_x1000_get_clk_div(rate, &chip->dds_rate);
> > + break;
> > default:
> > clk_div = ssp_get_clk_div(drv_data, rate);
> It would be nice to have a break here as well, but I think we also may
> change this to if-else-if construction.
No. Using if/else chains is an antipattern - think what happens when a
new hardware variant needs slightly different handling again.
Attachment:
signature.asc
Description: Digital signature
