Re: [PATCH] SPI: BCM2835: fix all checkpath --strict messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 19, 2015 at 09:01:50AM +0000, kernel@xxxxxxxxxxxxxxxx wrote:

Looks like I did get these but they took a while to come through...
odd.

> -static int bcm2835_spi_start_transfer(struct spi_device *spi,
> -		struct spi_transfer *tfr)
> +static int bcm2835_spi_start_transfer(
> +	struct spi_device *spi,
> +	struct spi_transfer *tfr)

Like Stephen says I'm not 100% sure what issues this is fixing but I
have to say I find the overall result worse.  It's possible the
warning is something reasonable but without knowing what it is it's hard
to say, I do like to see at least the first argument on the same line as
the function name though.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux