Re: [PATCH] spi: trigger trace event for message-done before mesg->complete

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 19, 2015 at 12:48:42PM +0100, Uwe Kleine-König wrote:
> On Thu, Mar 19, 2015 at 11:24:30AM +0000, Mark Brown wrote:

> > Sure, but it's better to write it up in terms of a generic driver - it's
> > the difference between "let's work around this driver" and "the core
> > isn't doing the right thing for drivers here".

> OK, so something like:

> spi: trigger trace event for message-done before mesg->complete
> 
> The message's complete callback might (permissibly) free the memory that
> holds the message. As recording the trace event for the end of a
> transfer accesses this message the recording is better done first.

Yes, that's the sort of thing I was looking for - it just makes the
review a bit easier.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux