Re: [PATCH 2/4] spi: imx: checkpatch cleanup

[aurélien bouin <a.bouin@xxxxxxxxx>]

Hello,
It does not change readability ... Often breaks are in functions parameters ...
Up to you

2015-02-12 13:42 GMT+01:00 Joe Perches <joe@xxxxxxxxxxx>:
>
> On Thu, 2015-02-12 at 13:07 +0100, Aurelien BOUIN wrote:
> > This patch solve various issue detected by checkpatch.pl
>
> trivia:
>
> > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> []
> > @@ -282,7 +282,8 @@ static unsigned int mx51_ecspi_clkdiv(unsigned int fin, unsigned int fspi,
> >               (post << MX51_ECSPI_CTRL_POSTDIV_OFFSET);
> >  }
> >
> > -static void __maybe_unused mx51_ecspi_intctrl(struct spi_imx_data *spi_imx, int enable)
> > +static void __maybe_unused mx51_ecspi_intctrl(struct spi_imx_data *spi_imx,
> > +             int enable)
>
> Perhaps it'd be better to use this style:
>
> __maybe_unused
> static void foo(...)
>
> ie:
>
> __maybe_unused
> static void mx51_ecspi_intctrl(struct spi_imx_data *spi_imx, int enable)
>
> etc..
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html