On Mon, Feb 02, 2015 at 03:30:33AM -0500, Nicholas Mc Guire wrote:
> - ret = wait_for_completion_timeout(&spi->c,
> - msecs_to_jiffies(SSP_TIMEOUT));
> - if (!ret) {
> + if (!wait_for_completion_timeout(&spi->c,
> + msecs_to_jiffies(SSP_TIMEOUT))) {
Your new indentation is pretty confusing here, I had to look twice to
realize that the msecs_to_jiffies() is still an argument to
wait_for_completion(). Generally arguments to functions should be
aligned with the opening ( for the function, or at least much more
deeply aligned than the function itself (as was the case with the
original code).
Attachment:
signature.asc
Description: Digital signature
