The pl08x driver originally selected S3C64XX_PL080 to avoid having the legacy Samsung DMA interfaces. Those are now gone, so the select is no longer needed, but it now causes problems when CONFIG_DMA_ENGINE is disabled: arch/arm/plat-samsung/built-in.o: In function `s3c64xx_spi0_set_platdata': :(.init.text+0x518): undefined reference to `pl08x_filter_id' This simply removes the 'select' to avoid this problem. Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 9b81b39de54e..7727660e9702 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -470,7 +470,6 @@ config SPI_S3C24XX_FIQ config SPI_S3C64XX tristate "Samsung S3C64XX series type SPI" depends on (PLAT_SAMSUNG || ARCH_EXYNOS) - select S3C64XX_PL080 if ARCH_S3C64XX help SPI driver for Samsung S3C64XX and newer SoCs. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] spi: pl08x: do not select S3C64XX_PL080
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: [PATCH] spi: pl08x: do not select S3C64XX_PL080
- From: Arnd Bergmann <arnd@xxxxxxxx>
- Date: Wed, 28 Jan 2015 14:27:06 +0100
- In-reply-to: <1957186.KORYFIrP42@wuerfel>
- User-agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
- Follow-Ups:
- Re: [PATCH] spi: pl08x: do not select S3C64XX_PL080
- From: Mark Brown
- Re: [PATCH] spi: pl08x: do not select S3C64XX_PL080
- References:
- [PATCH] spi/rockchip: avoid uninitialized-use warning
- From: Arnd Bergmann
- [PATCH] spi/rockchip: avoid uninitialized-use warning
- Prev by Date: [PATCH v2 03/15] spi/xilinx: Code cleanup
- Next by Date: [PATCH] spi/rockchip: avoid uninitialized-use warning
- Previous by thread: [PATCH] spi/rockchip: avoid uninitialized-use warning
- Next by thread: Re: [PATCH] spi: pl08x: do not select S3C64XX_PL080
- Index(es):
 |