On Tue, Nov 25, 2014 at 12:06:41PM -0800, Olof Johansson wrote: > On Mon, Sep 29, 2014 at 7:22 AM, Weike Chen <alvin.chen@xxxxxxxxx> wrote: > > This piece of work is derived from Dan O'Donovan's initial work for Intel Quark > > X1000 SPI enabling. > How about build testing for other platforms that share this driver > when you make changes to it? This is obviously completely broken. > Doing these constants under ifdef seems fragile at best, braindead at > worst. Please don't proliferate that coding style. > Mark, can you revert until Intel learns how to play well with others? Yeah. > This is from a pxa3xx-defconfig build: Ugh, why does this driver not have a COMPILE_TEST dependency? Not that it'd have caught this one.
Attachment:
signature.asc
Description: Digital signature
