On Mon, Nov 17, 2014 at 12:53:16PM +0100, Johan Hovold wrote: > On Mon, Nov 17, 2014 at 12:33:01PM +0200, Laurentiu Palcu wrote: > > Hi Johan, > > > > On Fri, Nov 14, 2014 at 11:56:45AM +0100, Johan Havold wrote: > > > On Thu, Nov 13, 2014 at 05:17:21PM +0200, Laurentiu Palcu wrote: > > > > Hi Johan, > > > > > > > > On Thu, Nov 13, 2014 at 01:27:28PM +0100, Johan Havold wrote: > > > > > On Wed, Nov 12, 2014 at 03:38:09PM +0200, Laurentiu Palcu wrote: > > > > And since there's no gain from using the global buffer why not simply > > > use stack allocated ones here as well (e.g. for both tx and rx above)? > > > > However, I will give this a shot though... Sounds reasonable and I could > > probably lose the struct constructs too if the struct contains just > > one field. > > You might want to keep the structs for single-field messages for > consistency reasons (also used in the other dln2 subdrivers). Ok, fair enough. laurentiu -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html