Re: [PATCH 2/4] spi: atmel: remove unnecessary #if defined(CONFIG_OF)

[Jingoo Han <jg1.han@xxxxxxxxxxx>]

On Wednesday, September 03, 2014 1:37 AM, Mark Brown wrote:
> On Tue, Sep 02, 2014 at 02:15:09PM +0200, Geert Uytterhoeven wrote:
> > On Tue, Sep 2, 2014 at 12:50 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> > > On Tue, Sep 02, 2014 at 12:24:00PM +0900, Jingoo Han wrote:
> > >> Remove unnecessary  #if defined(CONFIG_OF), because this is
> > >> already handled by the of_match_ptr macro.
> 
> > > Applied, thanks.
> 
> > If CONFIG_OF is not set, binary size is increased, as the OF match
> > table is still emitted, while it's no longer in use:
> 
> OK, I've discarded the series.

(+cc Axel Lin, Max Filippov)

OK, I see. I appreciate Geert's feedback. :-)

However, personally I don't like #ifdef guards. I think that
#ifdef guards can be removed for the same binary, regardless
of kernel config options.

In this case, the binary size is more important than #ifdef guards,
right?

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html