Re: [PATCH 2/4] spi: atmel: remove unnecessary #if defined(CONFIG_OF)

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Tue, Sep 2, 2014 at 12:50 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Tue, Sep 02, 2014 at 12:24:00PM +0900, Jingoo Han wrote:
>> Remove unnecessary  #if defined(CONFIG_OF), because this is
>> already handled by the of_match_ptr macro.
>
> Applied, thanks.

If CONFIG_OF is not set, binary size is increased, as the OF match
table is still emitted, while it's no longer in use:

m68k allmodconfig:

   text   data    bss    dec    hex filename
   7318    373      0   7691   1e0b drivers/spi/spi-atmel.o.old
   7710    373      0   8083   1f93 drivers/spi/spi-atmel.o.new
  10037    781      0  10818   2a42 drivers/spi/spi-atmel.ko.old
  10465    781      0  11246   2bee drivers/spi/spi-atmel.ko.new

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html