Re: [PATCH 1/2] spi: spi-adi-v3: Remove redundant OOM message

[Naveen Krishna Ch <naveenkrishna.ch@xxxxxxxxx>]

Hello Sachin,

On 13 June 2014 10:17, Sachin Kamat <sachin.kamat@xxxxxxxxxxx> wrote:
> Let memory subsystem do the error logging.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxxx>
> ---
>  drivers/spi/spi-adi-v3.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-adi-v3.c b/drivers/spi/spi-adi-v3.c
> index dcb2287c7f8a..19ea8fb78cc7 100644
> --- a/drivers/spi/spi-adi-v3.c
> +++ b/drivers/spi/spi-adi-v3.c
> @@ -660,10 +660,9 @@ static int adi_spi_setup(struct spi_device *spi)
>                 struct adi_spi3_chip *chip_info = spi->controller_data;
>
>                 chip = kzalloc(sizeof(*chip), GFP_KERNEL);
> -               if (!chip) {
> -                       dev_err(&spi->dev, "can not allocate chip data\n");
> +               if (!chip)
>                         return -ENOMEM;
> -               }
> +
>                 if (chip_info) {
>                         if (chip_info->control & ~ctl_reg) {
>                                 dev_err(&spi->dev,
> --
> 1.7.9.5
Reviewed-by: Naveen Krishna Chatradhi <ch.naveen@xxxxxxxxxxx>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-spi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Shine bright,
(: Nav :)
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html