On Thu, May 01, 2014 at 08:55:42PM +0200, Geert Uytterhoeven wrote: > On Thu, May 1, 2014 at 7:49 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > > From: Mark Brown <broonie@xxxxxxxxxx> > > @@ -1162,6 +1161,7 @@ static int spi_master_initialize_queue(struct spi_master *master) > > dev_err(&master->dev, "problem initializing queue\n"); > > goto err_init_queue; > You can just "return ret;" here... > > err_start_queue: > > -err_init_queue: > > spi_destroy_queue(master); > > +err_init_queue: > ... and kill the err_init_queue label. Yeah, I know. It's a stylistic thing - I tend to prefer to always use labels if they're used at all in a function even if we could return directly since it's more consistent. Not that I'm 100% consistent about that. > Apart from that: > Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Thanks.
Attachment:
signature.asc
Description: Digital signature
