Re: [PATCH v5 5/8 fix] mtd: m25p80: use the SPI nor framework

[Brian Norris <computersforpeace@xxxxxxxxx>]

+ Russell

On Fri, Feb 28, 2014 at 03:55:42PM +0800, Huang Shijie wrote:
> add back the dependency information in the Kconfig. 
> 
> ---
>  drivers/mtd/devices/Kconfig  |    2 +-
>  drivers/mtd/devices/m25p80.c | 1302 ++++--------------------------------------
>  2 files changed, 106 insertions(+), 1198 deletions(-)
> 
> diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
> index 0128138..004b17b 100644
> --- a/drivers/mtd/devices/Kconfig
> +++ b/drivers/mtd/devices/Kconfig
> @@ -80,7 +80,7 @@ config MTD_DATAFLASH_OTP
>  
>  config MTD_M25P80
>  	tristate "Support most SPI Flash chips (AT26DF, M25P, W25X, ...)"
> -	depends on SPI_MASTER
> +	depends on SPI_MASTER && MTD_SPI_NOR_BASE
>  	help
>  	  This enables access to most modern SPI flash chips, used for
>  	  program and data storage.   Series supported include Atmel AT26DF,

Now that M25P80 depends on MTD_SPI_NOR_BASE (which I proposed to rename
to MTD_SPI_NOR a few hours ago), shouldn't we be updating everybody's
defconfigs? As it stands, the defconfigs that use M25P80 will just drop
it silently when built.

And if so, I'm not sure how this should be handled. Should defconfig
patches be sent to their respective arch maintainers?

Also, I think m25p80.c is no longer a "self-contained MTD device driver"
and should be moved under drivers/mtd/spi-nor/.

(Once these questions are settled, did you want to handle cooking the
patches, Huang, or should I?)

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html