Re: [PATCH RFC] spi: efm32: Make "efm32,location" property optional

[Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>]

Hi Axel,

On Mon, Apr 07, 2014 at 11:18:52AM +0800, Axel Lin wrote:
> The spi driver still works even if "efm32,location" property is not provided.
> Thus make "efm32,location" property optional.
good catch. The changelog is wrong though. You don't make the property
optional, you only adapt the documentation to reality. It would be also
nice to mention the default value (i.e. keeping what is already
configured in the hardware, so its either the reset default 0 or
whatever the bootloader did.) OTOH I'm not sure if that should go into
the binding doc as it sounds Linux specific?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html