Re: [PATCH v2] spi: nuc900: Fix setting multiple bits settings in register

[Axel Lin <axel.lin@xxxxxxxxxx>]

2014-03-27 0:48 GMT+08:00 Mark Brown <broonie@xxxxxxxxxx>:
> On Fri, Mar 21, 2014 at 10:40:23PM +0800, Axel Lin wrote:
>> The correct way to set multiple bits settings is always clear these
>> bit fields before set new settings.
>>
>> Current code does not cause problem because the reset value of these
>> bit fields are 0, and these settings only set once during probe.
>
> This doesn't seem to apply against current code, can you please check
> and resend?
It's because v1 is applied.
I personally do not have strong preference between v1 and v2.
Is it ok to keep it as is since it's applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html