RE: [PATCH] SPI: Add driver for Cadence SPI controller

[Harini Katakam <harini.katakam@xxxxxxxxxx>]

Hi Rob,

> -----Original Message-----
> From: Rob Herring [mailto:robherring2@xxxxxxxxx]
> Sent: Monday, March 17, 2014 6:17 PM
> To: Harini Katakam
> Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Rob
> Landley; Mark Brown; Grant Likely; devicetree@xxxxxxxxxxxxxxx; linux-
> doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> spi@xxxxxxxxxxxxxxx; Michal Simek
> Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
>
> On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam <harinik@xxxxxxxxxx>
> wrote:
> > Add driver for Cadence SPI controller. This is used in Xilinx Zynq.
> >
> > Signed-off-by: Harini Katakam <harinik@xxxxxxxxxx>
> > ---
>
> > +- reg                  : Physical base address and size of SPI registers map.
> > +- interrupts           : Property with a value describing the interrupt
> > +                         number.
> > +- interrupt-parent     : Must be core interrupt controller
> > +- clock-names          : List of input clock names - "ref_clk", "pclk"
> > +                         (See clock bindings for details).
> > +- clocks               : Clock phandles (see clock bindings for details).
> > +- num-chip-select      : Number of chip selects used.
>
> See Documentation/devicetree/bindings/spi/spi-bus.txt. Use "num-cs"
> here.

I'll check that.
> > +
> > +       irq = platform_get_irq(pdev, 0);
> > +       if (irq < 0) {
>
> I believe this returns NO_IRQ which could be 0.
>
> s/</<=/
>
> > +       dev_dbg(&pdev->dev, "suspend succeeded\n");
>
> Not needed. The kernel already has suspend/resume tracing printks.

Will remove.

> > +       dev_dbg(&pdev->dev, "resume succeeded\n");
>
> Not needed. The kernel already has suspend/resume tracing printks.

Will remove.

Regards,
Harini



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html