Re: [PATCH] SPI: Add driver for Cadence SPI controller

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Mon, Mar 17, 2014 at 2:22 PM, Michal Simek <monstr@xxxxxxxxx> wrote:
>>> +       return 0;
>>> +}
>>> +
>>> +static SIMPLE_DEV_PM_OPS(cdns_spi_dev_pm_ops, cdns_spi_suspend,
>>> +                        cdns_spi_resume);
>>> +
>>> +/* Work with hotplug and coldplug */
>>> +MODULE_ALIAS("platform:" CDNS_SPI_NAME);
>>
>> Not sure, but I don't think this should be needed.
>
> I don't know too.

A plain platform device driver needs the MODULE_ALIAS, unless there's
a "MODULE_DEVICE_TABLE(platform, ...)", which doesn't exist in this driver.

However, as the driver fails in the absence of DT:

      ret = of_property_read_u16(pdev->dev.of_node, "num-chip-select",
                                  &master->num_chipselect);
      if (ret < 0) {
              dev_err(&pdev->dev, "couldn't determine num-chip-select\n");
              goto clk_dis_all;
      }

it won't work (yet) as a plain platform device driver.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html