Re: [PATCH] spi: coldfire-qspi: Fix bits per word setting when t->bits_per_word is not set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 27, 2014 at 10:09:59AM -0700, Stephen Warren wrote:
> On 02/26/2014 06:05 PM, Axel Lin wrote:
> > This ensures to use spi_device's bits_per_word setting when t->bits_per_word is
> > not set. This looks like a bug introduced by commit 24778be20f8
> > "spi: convert drivers to use bits_per_word_mask".

> I thought the SPI core already contained this kind of logic, so that
> drivers could rely on t->bits_per_word always being set up? Yes, this:

Indeed - if there weren't such logic the better fix would be to add it.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux