Sasha Levin, le mar. 07 juin 2022 13:47:57 -0400, a ecrit: > From: Zheng Bin <zhengbin13@xxxxxxxxxx> > > [ Upstream commit 106101303eda8f93c65158e5d72b2cc6088ed034 ] > > softsynth_probe misses a call misc_deregister() in an error path, this > patch fixes that. > > Signed-off-by: Zheng Bin <zhengbin13@xxxxxxxxxx> > Link: https://lore.kernel.org/r/20220511032937.2736738-1-zhengbin13@xxxxxxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> > --- > drivers/accessibility/speakup/speakup_soft.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c > index 19824e7006fe..786dc5d080f3 100644 > --- a/drivers/accessibility/speakup/speakup_soft.c > +++ b/drivers/accessibility/speakup/speakup_soft.c > @@ -397,6 +397,7 @@ static int softsynth_probe(struct spk_synth *synth) > synthu_device.name = "softsynthu"; > synthu_device.fops = &softsynthu_fops; > if (misc_register(&synthu_device)) { > + misc_deregister(&synth_device); > pr_warn("Couldn't initialize miscdevice /dev/softsynthu.\n"); > return -ENODEV; > } > -- > 2.35.1 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.
