On Wed, Feb 8, 2017 at 11:04 PM, Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> wrote: > Okash Khawaja, on Wed 08 Feb 2017 22:51:15 +0000, wrote: >> This moves the call to spk_stop_serial_interrupt() function into >> release() method of respective synths. > > Again, you need to say the "why": we don't want to hardcode calling > spk_stop_serial_interrupt() in synth_release(), and we don't actually > need to make it a method, making the release method call it is fine > enough. > spk_stop_serial_interrupt() is not a method. release method calls it. I think that's what I have said in the description. I'll add the reason why. > Samuel _______________________________________________ Speakup mailing list Speakup@xxxxxxxxxxxxxxxxx http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup
