Re: [PATCH 3/5] staging: speakup: refactor spk_stop_serial_interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Okash Khawaja, on Wed 08 Feb 2017 22:51:15 +0000, wrote:
> This moves the call to spk_stop_serial_interrupt() function into
> release() method of respective synths.

Again, you need to say the "why": we don't want to hardcode calling
spk_stop_serial_interrupt() in synth_release(), and we don't actually
need to make it a method, making the release method call it is fine
enough.

Samuel
_______________________________________________
Speakup mailing list
Speakup@xxxxxxxxxxxxxxxxx
http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup




[Index of Archives]     [Linux for the Blind]     [Fedora Discussioin]     [Linux Kernel]     [Yosemite News]     [Big List of Linux Books]
  Powered by Linux