Aleksei <lexa@xxxxxxxxx> writes: > Hi all. > > In attachment you can find a patch that fixes two types of warning: > WARNING: Block comments use a trailing */ on a separate line > WARNING: Block comments use * on subsequent lines Hi Aleksei, Your patch looks fine to me. I found one change you probably need to make, but I'll point it out at the end of the message, since it's minor. Anyway, glad to hear of your interest in Speakup! I'm glad to help with any pointers I can give, but my knowledge of the code base is very stale at this point. > P.S. I'm not sure if I'm writing to a correct mailing list. If i'm > mistaken, could you please point me a correct mail list for discussion > about speakup driver. Yes, this is the correct list for discussions of Speakup. However, Speakup is now in staging, so any patches need to go to another mailing list where staging drivers are developed. The homepage for that list can be found at: http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel I don't know what will happen if you Cc your patch to both the staging list and this one. Hopefully it would go to both lists, but I guess it depends on mailman configuration. Also the Speakup list does not allow posts from non-subscribers. Now on to the patch: > diff --git a/drivers/staging/speakup/speakup_acnt.h b/drivers/staging/speakup/speakup_acnt.h > index 6376fca..5858ffe 100644 > --- a/drivers/staging/speakup/speakup_acnt.h > +++ b/drivers/staging/speakup/speakup_acnt.h > @@ -6,10 +6,12 @@ > > /* Port Status Flags */ > #define SYNTH_READABLE 0x01 /* mask for bit which is nonzero if a > - byte can be read from the data port */ > + * byte can be read from the data port > + */ Looks like you need a space between the final tab and the * in the last line here. Regards, -- Chris _______________________________________________ Speakup mailing list Speakup@xxxxxxxxxxxxxxxxx http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup
