Re: [PATCH] staging: speakup: fix coding style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Domagoj Trsan, le Fri 05 Sep 2014 08:52:23 +0200, a écrit :
> This patch fix various coding style issues.

Thanks for the  work

> diff --git a/drivers/staging/speakup/i18n.h b/drivers/staging/speakup/i18n.h
> index dd338f4..46b8aee 100644
> --- a/drivers/staging/speakup/i18n.h
> +++ b/drivers/staging/speakup/i18n.h
> @@ -106,19 +106,26 @@ enum msg_index_t {
>  	MSG_KEYNAMES_START,
>  	MSG_KEYNAME_ESC = MSG_KEYNAMES_START,
>  	MSG_KEYNAME_1, MSG_KEYNAME_2, MSG_KEYNAME_3, MSG_KEYNAME_4,
> -	MSG_KEYNAME_5, MSG_KEYNAME_6, MSG_KEYNAME_7, MSG_KEYNAME_8, MSG_KEYNAME_9,
> +	MSG_KEYNAME_5, MSG_KEYNAME_6, MSG_KEYNAME_7, MSG_KEYNAME_8,
> +	MSG_KEYNAME_9,
>  	MSG_KEYNAME_0, MSG_KEYNAME_DASH, MSG_KEYNAME_EQUAL, MSG_KEYNAME_BS,
>  	MSG_KEYNAME_TAB,
> -	MSG_KEYNAME_Q, MSG_KEYNAME_W, MSG_KEYNAME_E, MSG_KEYNAME_R, MSG_KEYNAME_T,
> -	MSG_KEYNAME_Y, MSG_KEYNAME_U, MSG_KEYNAME_I, MSG_KEYNAME_O, MSG_KEYNAME_P,
> +	MSG_KEYNAME_Q, MSG_KEYNAME_W, MSG_KEYNAME_E, MSG_KEYNAME_R,
> +	MSG_KEYNAME_T,
> +	MSG_KEYNAME_Y, MSG_KEYNAME_U, MSG_KEYNAME_I, MSG_KEYNAME_O,
> +	MSG_KEYNAME_P,

Could you please completely reformat it? I.e. join T with YUIO, and thus
O has to go on the next line, with P.  Just putting what goes out of the
80th columns on the next line makes the whole thing quite ugly :)

Please also post the result of git diff -w -B, so we can easily check
the actual code changes, if any.

Samuel
_______________________________________________
Speakup mailing list
Speakup@xxxxxxxxxxxxxxxxx
http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup





[Index of Archives]     [Linux for the Blind]     [Fedora Discussioin]     [Linux Kernel]     [Yosemite News]     [Big List of Linux Books]
  Powered by Linux