Wouldn't the instructions be better if they were simply saying ``pip install ply git`` (or whatever), so no extra requirements file is needed? -- zvr -----Original Message----- From: Nicky Chorley <ndchorley@xxxxxxxxx> Sent: Friday, 6 August, 2021 08:45 To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> Cc: Nicky Chorley <ndchorley@xxxxxxxxx>; linux-spdx@xxxxxxxxxxxxxxx Subject: Re: Fwd: scripts/spdxcheck.py's third-party dependencies On Thu, 5 Aug 2021, Greg KH wrote: > But we do not use pip to do kernel builds, so what is this going to > help with? It's just about making people's lives easier for running the spdxcheck.py script - not everyone will have the third-party libraries installed, so listing them means they can be installed easily. For example: diff --git a/scripts/README.spdxcheck b/scripts/README.spdxcheck new file mode 100644 index 000000000000..80bb6308e5c5 --- /dev/null +++ b/scripts/README.spdxcheck @@ -0,0 +1,6 @@ +The script spdxcheck.py requires installation of some third party +libraries. These are listed in ``requirements-spdxcheck.txt`` and can +be installed with + +``pip install -r requirements-spdxcheck.txt`` + diff --git a/scripts/requirements-spdxcheck.txt b/scripts/requirements-spdxcheck.txt new file mode 100644 index 000000000000..9a4633040897 --- /dev/null +++ b/scripts/requirements-spdxcheck.txt @@ -0,0 +1,3 @@ +ply +GitPython + I'll reformat as a proper patch with any changes if this is useful. Best, Nicky Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928
