Em Thu, Apr 06, 2023 at 06:31:32PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Apr 06, 2023 at 06:11:03PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Apr 06, 2023 at 10:02:57PM +0200, Miguel Ojeda escreveu: > > > On Thu, Apr 6, 2023 at 9:58 PM Liam R. Howlett <Liam.Howlett@xxxxxxxxxx> wrote: > > > > > > > > Any chance of this being accepted? I'm looking to use this in the radix > > > > test suite and would rather not duplicate code. > > > > > > That would be up to the `tools/perf/` maintainers. > > > > Thanks, applied, > > So, I noticed some missing conversions, fixed that, but then when trying > to test build it with: > > make -C tools/perf build-test > > I stumbled on this: > > make_with_gtk2: cd . && make GTK2=1 -j32 DESTDIR=/tmp/tmp.5AP8tPJgiT > cd . && make GTK2=1 -j32 DESTDIR=/tmp/tmp.5AP8tPJgiT > BUILD: Doing 'make -j32' parallel build > HOSTCC fixdep.o > HOSTLD fixdep-in.o > <SNIP> > CC trace/beauty/ioctl.o > In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9, > from /usr/include/glib-2.0/glib/gtypes.h:34, > from /usr/include/glib-2.0/glib/galloca.h:34, > from /usr/include/glib-2.0/glib.h:32, > from /usr/include/glib-2.0/gobject/gbinding.h:30, > from /usr/include/glib-2.0/glib-object.h:24, > from /usr/include/glib-2.0/gio/gioenums.h:30, > from /usr/include/glib-2.0/gio/giotypes.h:30, > from /usr/include/glib-2.0/gio/gio.h:28, > from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30, > from /usr/include/gtk-2.0/gdk/gdk.h:32, > from /usr/include/gtk-2.0/gtk/gtk.h:32, > from ui/gtk/gtk.h:8, > from ui/gtk/helpline.c:6: > /usr/include/glib-2.0/glib/gmacros.h:637:28: error: missing ')' after "__has_attribute" > 637 | #if g_macro__has_attribute(fallthrough) > | ^~~~~~~~~~~ I'm now trying with: diff --git a/tools/perf/ui/gtk/browser.c b/tools/perf/ui/gtk/browser.c index 8f3e43d148a8560b..d2dadf3873fbdf41 100644 --- a/tools/perf/ui/gtk/browser.c +++ b/tools/perf/ui/gtk/browser.c @@ -1,9 +1,9 @@ // SPDX-License-Identifier: GPL-2.0 +#include "gtk.h" #include "../evsel.h" #include "../sort.h" #include "../hist.h" #include "../helpline.h" -#include "gtk.h" #include <signal.h>
